rely on plugin version instead of terminal type for notifications#2
Merged
harryalbert merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
zachbai
approved these changes
Apr 6, 2026
harryalbert
force-pushed
the
harry/app-3620-get-claude-code-plugin-working-over-ssh
branch
from
2d13cd2 to
79c61b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't rely on the terminal being warp/gate access on this being the case, because if you're ssh-ing into another terminal using warp the plugin won't work as is.
Instead, we should rely on the declared version of the plugin that's supported. This PR changes it so that we declare support in the client over ssh, so with this change the plugin works over ssh
Demo of ssh working with notifications: https://www.loom.com/share/ff3749cb62fd4a80887775ef771f8036