Skip to content

switch to more specific message sent and permission replied hooks#1

Merged
harryalbert merged 2 commits intomainfrom
harry/make-permissions-hooks-more-specific
Mar 24, 2026
Merged

switch to more specific message sent and permission replied hooks#1
harryalbert merged 2 commits intomainfrom
harry/make-permissions-hooks-more-specific

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented Mar 24, 2026

This is a quick fix for the initial opencode plugin commit, wherein the hooks around the message being updated and the prompt being sent were a little too general (we were using the same message updated hook both for the initial prompt send event and for the tool use acceptance event, but it was also firing when the message completed and we need to distinguish all these things).

This updates the plugin to use the specific "permission.replied" and "chat.message" hooks, making our implementation more robust and easier to reason about.

It also adds a bunch of tests for the various plugin functionality (mirroring the cli tests in the claude code plugin)

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert harryalbert marked this pull request as ready for review March 24, 2026 21:38
@harryalbert harryalbert assigned zachbai and unassigned zachbai Mar 24, 2026
@harryalbert harryalbert requested a review from zachbai March 24, 2026 21:48
@harryalbert harryalbert merged commit 422c40a into main Mar 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants