Skip to content

Document tab and group pinning#342

Merged
johnturcoo merged 2 commits into
mainfrom
john/tab-pinning
Jul 17, 2026
Merged

Document tab and group pinning#342
johnturcoo merged 2 commits into
mainfrom
john/tab-pinning

Conversation

@johnturcoo

@johnturcoo johnturcoo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a top-level section for pinning tabs and tab groups.
  • Document pinned ordering, persistence, layout support, and grouped-tab behavior.
  • Add procedures for pinning and unpinning tabs and groups, including configurable keyboard shortcuts.
  • Update the Tabs page description to cover groups and pinning.

Validation

  • python3 .agents/skills/style_lint/style_lint.py targeted at src/content/docs/terminal/windows/tabs.mdx (0 issues)
  • npm run build (347 pages built)
  • git diff --check

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 17, 2026
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 17, 2026 7:43pm

Request Review

@oz-for-oss

oz-for-oss Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@johnturcoo

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds tab and tab-group pinning guidance to the Tabs documentation and updates the page description to mention groups and pinning. I did not find correctness, security, or spec-alignment blockers; the only feedback is minor docs-style punctuation in the new numbered procedures.

Concerns

  • Minor: the newly added numbered procedure steps should end with periods for style-guide consistency.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve with nits

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment on lines +136 to +137
1. Right-click the tab you want to keep at the front.
2. Click **Pin tab**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 [NIT] Numbered procedure steps should end with periods per the docs style guide.

Suggested change
1. Right-click the tab you want to keep at the front.
2. Click **Pin tab**.
1. Right-click the tab you want to keep at the front.
2. Click **Pin tab**.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol this diff looks identical to before?

Comment on lines +147 to +148
1. Right-click the group's header.
2. Click **Pin group**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 [NIT] Numbered procedure steps should end with periods per the docs style guide.

Suggested change
1. Right-click the group's header.
2. Click **Pin group**.
1. Right-click the group's header.
2. Click **Pin group**.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@johnturcoo
johnturcoo requested a review from hongyi-chen July 17, 2026 19:39
@johnturcoo
johnturcoo merged commit eff8f2e into main Jul 17, 2026
8 checks passed
@johnturcoo
johnturcoo deleted the john/tab-pinning branch July 17, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants