docs: document Pinned tabs#339
Conversation
Pinned tabs (the PinnedTabs feature flag) went GA. Document how to pin and unpin individual tabs and whole tab groups from the tab right-click menu, and note the keyless keyboard shortcuts. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a Pinned tabs section to the existing Tabs documentation, covering individual tab pinning, tab group pinning, and keyless shortcut actions. I verified the documented behavior and keybinding labels against the local Warp source referenced by the PR.
Concerns
- One non-blocking docs-style issue: the new Settings path should orient readers to the Warp app before the menu path.
- No approved spec context was provided, so there was no implementation-vs-spec drift to assess from the attached context.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| ### Keyboard shortcuts | ||
|
|
||
| Pinning actions ship without default keyboard shortcuts. Assign your own in **Settings** > **Keyboard shortcuts** for **Pin current tab**, **Unpin current tab**, **Pin current tab group**, and **Unpin current tab group**. |
There was a problem hiding this comment.
💡 [SUGGESTION] Orient readers before the Settings path so the instruction follows the docs style guide for first references to app surfaces.
| Pinning actions ship without default keyboard shortcuts. Assign your own in **Settings** > **Keyboard shortcuts** for **Pin current tab**, **Unpin current tab**, **Pin current tab group**, and **Unpin current tab group**. | |
| Pinning actions ship without default keyboard shortcuts. In the Warp app, go to **Settings** > **Keyboard shortcuts** to assign shortcuts for **Pin current tab**, **Unpin current tab**, **Pin current tab group**, and **Unpin current tab group**. |
1 participant
Summary
Documents the Pinned tabs feature, which went GA (the
PinnedTabsfeature flag is now enabled by default). Users can pin individual tabs and whole tab groups so they stay at the front of the tab bar and are protected from reordering.What changed
terminal/windows/tabs.mdxcovering:Source of truth:
app/src/workspace/view/tab_grouping.rs,app/src/tab.rs, and thePinnedTabsflag incrates/warp_features/src/lib.rs(public warpdotdev/warp repo).Audit context
Generated by the
missing_docsdrift-watch audit. This finding came from thePinnedTabsflag movingpreview -> ga. The companion surface-map + snapshot updates ship in the audit-bookkeeping PR.Conversation: https://staging.warp.dev/conversation/ce1c5f13-b8a2-497f-843e-57f84d63b745
Run: https://oz.staging.warp.dev/runs/019f7105-5e3a-7d03-8d21-1a7784c46f9a
This PR was generated with Oz.