Repository navigation
Conversation
Since Rails 7.0, Journey::Path::Pattern#ast returns a Journey::Ast wrapper (and is cleared on eager_load!), so PathResolver failed on ast.type. Pattern#spec returns the raw node tree on every Rails version.
- Relax actionpack / railties upper bound to < 8.2 - Require open_api >= 0.6.3, the first version allowing activesupport 7.2+ - Drop bundler ~> 2.0 dev dependency, which conflicts with Bundler 4 bundled with Ruby 4.0 - Test Ruby 3.3, 3.4, 4.0 and Rails 7.0 to 8.1 on CI - Remove Code Climate coverage upload, whose API was shut down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
actionpack/railties < 7.2になっているrake api_specが Rails 7.0 以降、NoMethodError: undefined method 'type' for an instance of ActionDispatch::Journey::Astで失敗するWhat
RoutesFinderがroute.path.astではなくroute.path.specを使うように直すPattern#astはJourney::Astというラッパーを返し、eager_load!の後は nil になるPattern#specは Rails 5.0〜8.1 のどの版でも、生のノードツリーを返すactionpack/railtiesの上限を< 8.2にし、open_api >= 0.6.3を必須にするbundler ~> 2.0を削除し、CI を Ruby 3.3 / 3.4 / 4.0 と Rails 7.0〜8.1 にし、Code Climate を削除する。どれも Support Ruby 3.3, 3.4, 4.0 and Rails 8.1 open_api#18 と同じ内容確認したこと
.ast/.ast.rootに戻す変異や、パラメータを落とす変異で落ちるrake api_specを実行したmerge の順番
open_api >= 0.6.3を解決できずに全セルが失敗するbundle exec rake releaseを実行する