-
Notifications
You must be signed in to change notification settings - Fork 25
Beginning of manifest validations using SHACL #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rubensworks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really useful, thanks for the effort @Tpt.
When validation fails, how will it be reported within the logs?
Does it show the filename of the file that was invalid (with line number)?
20d03ae to
f889a94
Compare
|
@rubensworks Yes! Here is an example: https://github.com/w3c/rdf-tests/actions/runs/20309967842/job/58338033783?pr=260#step:4:11 |
|
I tried on all the manifests and they were clean. 🎆 How about putting the shapes in a different place to |
Co-authored-by: Andy Seaborne <andy@apache.org>
@afs We can but I wanted to avoid yet an other directory and |
|
If you want, though I was allowing for future build related files. But I'd suggest not calling the file "manifest-shape.ttl". Not all manifest files are "manifest.ttl". They don't even all start "manifest", they do all include "manifest" as a substring.
So maybe: |
Only validates some fields of RDF tests for now