Skip to content

Conversation

@Tpt
Copy link
Contributor

@Tpt Tpt commented Dec 16, 2025

Only validates some fields of RDF tests for now

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really useful, thanks for the effort @Tpt.

When validation fails, how will it be reported within the logs?
Does it show the filename of the file that was invalid (with line number)?

@Tpt Tpt force-pushed the tpt/shacl branch 2 times, most recently from 20d03ae to f889a94 Compare December 17, 2025 16:30
@Tpt
Copy link
Contributor Author

Tpt commented Dec 17, 2025

@rubensworks Yes! Here is an example: https://github.com/w3c/rdf-tests/actions/runs/20309967842/job/58338033783?pr=260#step:4:11

@afs
Copy link
Contributor

afs commented Dec 17, 2025

I tried on all the manifests and they were clean. 🎆

How about putting the shapes in a different place to /ns/ such as /build/ or /.github/shapes/?

Co-authored-by: Andy Seaborne <andy@apache.org>
@Tpt
Copy link
Contributor Author

Tpt commented Dec 17, 2025

How about putting the shapes in a different place to /ns/ such as /build/ or /.github/shapes/?

@afs We can but I wanted to avoid yet an other directory and /.github/shapes/ is a bit burried for something that is not specific to the CI. What about putting the shapes into a manifest-shape.ttl file in the root directory?

@afs
Copy link
Contributor

afs commented Dec 17, 2025

If you want, though I was allowing for future build related files. validate_manifest.py could go in there as well.

But I'd suggest not calling the file "manifest-shape.ttl".

Not all manifest files are "manifest.ttl". They don't even all start "manifest", they do all include "manifest" as a substring.

find . -name \*manifest\*.ttl

So maybe:
"validation-shapes.ttl"
"shapes-for-tests.ttl"

@Tpt
Copy link
Contributor Author

Tpt commented Dec 23, 2025

@afs Done. aa30368

I am not sure to see the problem with naming the shape file "manifest". The main RDF node of the files listing tests uses the mf:Manifest class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants