T8595: add AGENTS.md + Copilot symlink for the vyos-org central CodeRabbit baseline#4
T8595: add AGENTS.md + Copilot symlink for the vyos-org central CodeRabbit baseline#4andamasov wants to merge 2 commits into
Conversation
…abbit baseline Authority: T8595 (AGENTS.md fleet rollout). 🤖 Generated by [robots](https://vyos.io)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 LanguageToolAGENTS.md[uncategorized] ~32-~32: The official name of this software platform is spelled with a capital “H”. (GITHUB) 🔍 Remote MCP Context7Additional relevant facts for PR review
Sources:
🔀 Multi-repo context ansible/ansibleLinked repositories findingsansible/ansible
Conclusion: The PR adding AGENTS.md and a copilot symlink in vyos/coderabbit is contextually relevant: ansible/ansible already maintains AGENTS.md and contains many vyos-related redirects and tests that may rely on organization-wide agent guidance or public-org framing. This cross-repo linkage is supported by direct references found above. 🔇 Additional comments (7)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds an org-level ChangesCodeRabbit baseline configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot review |
Ran Copilot follow-up review on this PR state: no additional changes were required for commit |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Line 5: Update the sentence on Line 5 so it correctly states that repositories
that include `.coderabbit.yaml` with `inheritance: true` will merge with (not
opt out of) the central CodeRabbit baseline; specifically, change the wording
that currently implies exclusion to explicitly say `inheritance: true` enables
merging with the central baseline defined by CodeRabbit's central-configuration
(and keep references to the repo name lookup `coderabbit` and the `vyos/<repo>`
application behavior intact).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 648943ec-db56-43f6-968a-79ca08d63ce5
📒 Files selected for processing (2)
.github/copilot-instructions.mdAGENTS.md
📜 Review details
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:33.428Z
Learning: Agents should be designed with clear separation of concerns - each agent should have a single, well-defined responsibility
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:33.428Z
Learning: Agent communication should use standardized message formats and protocols
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:33.428Z
Learning: Agents should include error handling and graceful degradation mechanisms
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:33.428Z
Learning: Agent state management should be explicit and traceable
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:39.339Z
Learning: Ensure Org-UI Web dashboard (Global Overrides) stays empty — YAML configuration is the single source of truth; any setting present in Org-UI should be lifted into `.coderabbit.yaml` and the Org-UI editor cleared
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:39.339Z
Learning: Commit and PR titles must follow the format `T<num>: <description>` or `scope: T<num>: <description>` as enforced by Mergify central rules
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:39.339Z
Learning: Keep the default branch as `production` with public visibility for the coderabbit configuration repository
Learnt from: CR
Repo: vyos/coderabbit
Timestamp: 2026-05-16T17:49:39.339Z
Learning: Do not rename the coderabbit repository as CodeRabbit's central-configuration feature looks up the literal repo name `coderabbit` in the org; renaming breaks the integration
🪛 LanguageTool
AGENTS.md
[uncategorized] ~32-~32: The official name of this software platform is spelled with a capital “H”.
Context: ...anchesaddsgit-actions(used by its.github` repo); this list does not. ## Convent...
(GITHUB)
🔍 Remote MCP Context7
Relevant facts found (concise, directly applicable to this PR review)
-
Central
.coderabbit.yamlbehavior: adding AGENTS.md / central repo is the standard way to set org-wide defaults that repos inherit; repositories without their own.coderabbit.yamlwill receive those defaults. -
To enable deep/merged inheritance the central config must include
inheritance: trueat the root; that flag enables per-repo deep-merge behavior (child wins for scalars, objects merged, arrays merged with de-duplication). Verify AGENTS.md/.coderabbit.yaml references this flag if the intent is org-wide inheritance. -
Override semantics to check in review: repository-level
.coderabbit.yamlfiles take precedence for scalars; objects and arrays are merged according to documented rules — confirm AGENTS.md wording matches these semantics so maintainers understand override effects. -
Verification guidance: post-merge, run CodeRabbit auto-review (flip-to-ready) to ensure the central config is applied and that no unexpected repo-level diffs appear; this aligns with the PR's test plan.
Sources/tools used:
- Resolved relevant CodeRabbit documentation entry for queries: Context7 library resolution.
- Queried CodeRabbit docs for central configuration, inheritance flag, merge semantics, and merged-configuration examples.
🔀 Multi-repo context ansible/ansible
Linked repositories findings
ansible/ansible
- AGENTS.md exists at repo root and contains agent guidance and CI/testing commands relevant to reviewers/agents. [::ansible/ansible::AGENTS.md]
- Codebase contains extensive vyos redirects mapping module/plugin names to vyos implementations in lib/ansible/config/ansible_builtin_runtime.yml (many entries around lines ~7528–7560, ~8699–8782, ~8923–9444). These show Ansible provides built-in redirects for numerous vyos modules/plugins. [::ansible/ansible::lib/ansible/config/ansible_builtin_runtime.yml:7528-7560,8699-8782,8923-9444]
- Tests/reference fixtures mention AGENTS.md and include vyos-focused integration test targets:
- test/sanity/code-smell/package-data.py references 'AGENTS.md'. [::ansible/ansible::test/sanity/code-smell/package-data.py:36]
- Integration targets and modules under test/integration/targets/module_defaults reference vyos modules/plugins and vyosfacts (e.g., test_defaults.yml and collections plugins). [::ansible/ansible::test/integration/targets/module_defaults/test_defaults.yml:134-150, ::ansible/ansible::test/integration/targets/module_defaults/collections/ansible_collections/testns/testcoll/plugins/modules/vyosfacts.py:1-30]
Summary assessment: The coderabbit PR adding AGENTS.md and linking to ansible/ansible is relevant — ansible/ansible already maintains an AGENTS.md and contains many vyos redirects and tests that rely on vyos module names; this cross-repo linkage is valid context for reviewers.
🔇 Additional comments (2)
AGENTS.md (1)
26-46: LGTM!.github/copilot-instructions.md (1)
1-1: LGTM!
Address CodeRabbit L5 finding (PR #4) — the original wording could be read as saying inheritance: true causes consumers to be excluded from the central baseline, when in fact it enables deep-merge with the baseline. Rewrite to state the merge contract explicitly. 🤖 Generated by [robots](https://vyos.io)
Summary
Adds
AGENTS.mdat repo root with a.github/copilot-instructions.mdsymlink to../AGENTS.md, completing the AGENTS.md fleet rollout coverage for the vyos-org central CodeRabbit baseline.Content is intentionally divergent from
VyOS-Networks/coderabbit— see the "Cross-repo context" section for the public-org-specific framing (early_access on, Jira off, ansible/ansible linked).Authority: T8595, with T8764 / T8765 context.
Local CodeRabbit (Phase 0 per WD-1334): 0 findings.
Test plan
@copilot review) is clean🤖 Generated by robots