T8764: allow non-org-member chat + expand bot ignore list by andamasov · Pull Request #3 · vyos/coderabbit

andamasov · 2026-05-13T06:03:35Z

Summary

Two changes against the org-wide CodeRabbit baseline:

chat.allow_non_org_members: false → true. The vyos org is public-facing OSS; external contributors routinely open PRs and the previous setting blocked them from using @coderabbitai commands on their own PRs. Auto-review eligibility is unaffected — review skip rules remain governed by reviews.auto_review.
reviews.auto_review.ignore_usernames extended from [mergify[bot]] to mergify, mergify[bot], netlify, netlify[bot], claude, claude[bot]. Both the bare login and the [bot] suffix are listed because GitHub Apps use the [bot] form while service or human accounts may share the bare name; exact-match semantics per the schema mean listing both is required.

Schema-verification

chat.allow_non_org_members — boolean, schema line 1545.
reviews.auto_review.ignore_usernames — array of strings, exact-match on GitHub login (not email), schema line 541.

CodeRabbit gotcha — this PR is on a public repo

Per ~/.claude/data/github.md and the CodeRabbit inheritance docs, CodeRabbit ignores YAML config changes from PRs on public repos for security ("only the configuration from the base branch is applied for open source repositories"). This PR will therefore NOT receive a CodeRabbit auto-review of its YAML change itself; Copilot is the only bot review on the draft. The change takes effect post-merge.

Test plan

Diff inspected against current production
No schema validation errors from CodeRabbit
Effective config on a downstream consumer PR shows the new bot list and allow_non_org_members: true

Completes: IS-448
Advances: IS-430

🤖 Generated by robots

Two changes against the org-wide CodeRabbit baseline, motivated by fleet-wide noise from bot-authored PRs and chat lockouts on the public side: 1. `chat.allow_non_org_members: false` → `true`. The `vyos` org is public-facing OSS; external contributors routinely open PRs and the previous setting blocked them from using `@coderabbitai` commands on their own PRs. This does not change auto-review eligibility — review skip rules remain governed by `reviews.auto_review`. 2. `reviews.auto_review.ignore_usernames` extended from `[mergify[bot]]` to the full bot list of `mergify`, `mergify[bot]`, `netlify`, `netlify[bot]`, `claude`, `claude[bot]`. Both the bare login and the `[bot]` suffix are listed because GitHub Apps use the `[bot]` form while service or human accounts may share the bare name; exact-match semantics per the schema mean listing both is required to cover every variant. Net effect on per-repo `.coderabbit.yaml` files: a per-repo override that listed the same bots becomes redundant after this merges. Repos that need to chat-restrict (e.g. private commercial repos) can still set `chat.allow_non_org_members: false` at the repo level since inheritance is per-field. Advances: IS-430

coderabbitai · 2026-05-13T06:03:41Z

Warning

Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b767ede8-f0cc-4ed6-9033-5756a3fb7f80

📥 Commits

Reviewing files that changed from the base of the PR and between 788cfae and 5edeb78.

📒 Files selected for processing (1)

.coderabbit.yaml

📜 Recent review details

🧰 Additional context used

🔍 Remote MCP Context7

Perfect! I now have relevant documentation to support the PR review. Let me compile the findings:

Additional Context for PR Review

Configuration Settings Documentation

Based on CodeRabbit's official documentation, here are the key details relevant to the PR changes:

`chat.allow_non_org_members` Setting

The allow_non_org_members setting determines if non-organization members can interact with CodeRabbit in comment chats. Setting it to false restricts interactions to organization members for GitHub organization repositories, but does not affect automatic PR review eligibility. It defaults to true. This confirms the PR's stated intent that enabling this setting won't affect auto-review eligibility, which remains governed by reviews.auto_review settings.

`reviews.auto_review.ignore_usernames` Configuration

The ignore_usernames setting configures a list of usernames to be ignored by the auto-review process, where PRs from these users will be silently skipped. This is recommended for bots and service accounts. The documentation provides examples showing bot accounts with the [bot] suffix (e.g., dependabot[bot], renovate[bot], github-actions[bot]), which aligns with the PR's approach of including both bare and [bot] variants for each service.

Inheritance and Configuration Hierarchy

Organization-wide defaults can be set for reviews, auto-review settings, and path instructions through central configuration with an inheritance flag. This supports the commit message's note that per-repo overrides and field-level inheritance patterns are supported, allowing individual repos to override the organization-wide setting if needed.

🔇 Additional comments (2)

.coderabbit.yaml (2)

56-60: LGTM!

Also applies to: 62-62, 64-67

133-139: LGTM!

📝 Walkthrough

Summary by CodeRabbit

Chores
- Expanded bot account exclusions in automated review processes to cover additional service providers
- Enabled code review chat access for non-organization members in pull request discussions

Walkthrough

Updated .coderabbit.yaml configuration: expanded bot account filtering in auto-review ignore list to include mergify, netlify, claude and their [bot] variants, and enabled non-organization member chat access while preserving auto-review eligibility rules.

Changes

CodeRabbit Configuration

Layer / File(s)	Summary
Auto-review and chat access policy `.coderabbit.yaml`	Lines 56–67: `reviews.auto_review.ignore_usernames` expanded from `["mergify[bot]"]` to include `mergify`, `mergify[bot]`, `netlify`, `netlify[bot]`, `claude`, `claude[bot]`. Lines 133–139: `chat.allow_non_org_members` changed from `false` to `true`, enabling non-org members to interact via CodeRabbit chat while auto-review eligibility remains governed by `reviews.auto_review` settings.

Possibly related PRs

vyos/coderabbit#2: Modifies the same reviews.auto_review.ignore_usernames configuration to exclude mergify bot variants from auto-review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title clearly and concisely summarizes both main changes: enabling non-org-member chat and expanding the bot ignore list.
Description check	✅ Passed	Description is directly related to the changeset, providing detailed rationale for both configuration updates and schema references.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch yuriy/t8764-chat-non-org-members-and-bot-ignores

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

andamasov · 2026-05-13T06:03:55Z

@copilot review

Copilot · 2026-05-13T06:05:33Z

@copilot review

Reviewed. Current changes in 5edeb78 align with the PR intent, and I did not find any additional fixes needed at this time.

Copilot started work on behalf of andamasov May 13, 2026 06:04 View session

Copilot finished work on behalf of andamasov May 13, 2026 06:06

andamasov marked this pull request as ready for review May 13, 2026 06:23

andamasov merged commit ad39258 into production May 13, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T8764: allow non-org-member chat + expand bot ignore list#3

T8764: allow non-org-member chat + expand bot ignore list#3
andamasov merged 1 commit into
productionfrom
yuriy/t8764-chat-non-org-members-and-bot-ignores

andamasov commented May 13, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Additional Context for PR Review

Configuration Settings Documentation

`chat.allow_non_org_members` Setting

`reviews.auto_review.ignore_usernames` Configuration

Inheritance and Configuration Hierarchy

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Uh oh!

andamasov commented May 13, 2026

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

andamasov commented May 13, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Schema-verification

CodeRabbit gotcha — this PR is on a public repo

Test plan

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional Context for PR Review

Configuration Settings Documentation

chat.allow_non_org_members Setting

reviews.auto_review.ignore_usernames Configuration

Inheritance and Configuration Hierarchy

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Uh oh!

andamasov commented May 13, 2026

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

andamasov commented May 13, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading

`chat.allow_non_org_members` Setting

`reviews.auto_review.ignore_usernames` Configuration