docs: show useId with aria-labelledby#3393
Open
MukundaKatta wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Problem
The accessibility guide shows
aria-labelledbywith hard-codedidvalues. That works for a single page example, but reusable Vue components can be rendered multiple times and would then duplicate IDs.Proposed Solution
Add a short note and component example that uses
useId()to generate stable, per-instance IDs foraria-labelledby.Fixes #1510
Additional Information
Verification:
pnpm buildgit diff --checkAttempted:
pnpm typecurrently fails in.vitepress/config.tswith TS2352 for an existing plugin tuple cast unrelated to this page.pnpm exec prettier --check src/guide/best-practices/accessibility.mdcould not run because Prettier is not installed as a project dependency.