BinaryInput::read() implementation

[KAlO2]

Hello developers,

I can not understand this piece of code.
https://github.com/vsg-dev/VulkanSceneGraph/blob/master/src/vsg/io/BinaryInput.cpp#L195

Comparing className with "nullptr" seems weird to me. When reading a null object from a vsgb file, readValue<std::string> returns an empty string "" instead of "nullptr". So is this the intended behavior?

[robertosfield]

In the case when a class member variable is a pointer that can be null when you serialize to ascii or binary you need a way of declaring this as a nullptr.

You can't just write out pointers and read them back in as the objects will have a different location in memory on the read back, so you have to have a mechanism for writing out the objects associated with the pointer, then on re-load you have to load the object, then any other pointer in the scene graph that also pointed to the same original object also needs to keep pointing to the same pointer. The mechanism is what the objectIDMap[id] is for, but a nullptr is also a valid value that also needs a mechanism which is what the nullptr is about.

[KAlO2]

Can this line of code: if (className != "nullptr") be rewritten as if (className != "" && className != "nullptr")?
Because many warnings Unable to create instance of class : are printed on my side.

[robertosfield]

Perhaps these warnings are valid.

Do you have custom objects in your scene graph that don't implement serializers or do so incompletely?

[KAlO2]

I use the old .vsgb models, they are converted with old vsg version and the vsgconv tool.
OK. Thanks. I guess I can close this issue then :-)

[robertosfield]

How old .vsgb models? Are they published in place I can pull them down and test?