feat(competition): expose the champion family as bounded kit data - #577
Open
plind-junior wants to merge 1 commit into
Open
feat(competition): expose the champion family as bounded kit data#577plind-junior wants to merge 1 commit into
plind-junior wants to merge 1 commit into
Conversation
retrieval.strategy_params turns the reigning engine-lane strategy's
decision points into a closed, pydantic-bounded config surface. a kit
can now tune suspect penalties, the danger factor, update boosts, and
collapse thresholds - and auto-merge through the kit gate - because the
score plus the schema bounds cover everything such a submission can do.
the kit validator delegates the subtree to the same schema the runtime
builds the strategy from, so the gate and the engine cannot disagree
about a legal kit. defaults reproduce the promoted champion exactly, so
strategy_params: {} scores identically to the shipped default. the
dotted code hook (retrieval.strategy) stays out of the allowlist -
naming code to import is not data.
new ranking capabilities still enter as code through the human-reviewed
engine lane once; every configuration of them competes - and merges -
as data thereafter.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes the loop the engine lane deliberately leaves open: how does the ladder keep improving ranking without a human in the day-to-day merge path. answer: the reigning champion's decision points become bounded data.
retrieval.strategy_paramsexposes the champion family's knobs — suspect penalties, the relevance-scaled danger factor, update boosts, the conflict-collapse threshold, per-rule toggles — as a pydantic schema withextra="forbid"and hard bounds on every field (src/vouch/strategies/configured.py). defaults reproduce the promoted champion's constants exactly, verified by a parity test againstcontrib/strategies/relevance_guard.pyacross branch-covering candidates. a kit tuning these knobs is pure data, so it rides the existing kit gate: scored on the day's seeds, auto-merged on a dethrone, no human.the kit validator delegates the
strategy_paramssubtree to the same schema the runtime builds the strategy from — one schema, two callers, so the gate and the engine cannot disagree about what a legal kit is. the subtree fails closed when the schema is unavailable, yaml booleans are refused as numbers (same rule as the existing numeric knobs), and the dotted code hook (retrieval.strategy) stays out of the allowlist: naming code to import is not data.on the retrieval path, params take precedence over the dotted hook (data before code), an explicit bench strategy still wins over both, and invalid params degrade to "no strategy" — retrieval never fails because a ranking config is bad.
the division of labour docs/koth-ladder.md already promised is now mechanical: a new ranking capability enters as code through the human-reviewed engine lane once; every configuration of it thereafter competes — and merges — as data. verification: full ci gate green locally (pytest, mypy, ruff).