Expression constructors in python accept generators as an argument - #9410
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 7.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | decompress[u64, (10000, 4)] |
310.2 µs | 401.6 µs | -22.76% |
| ❌ | Simulation | take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=16] |
1 ms | 1.2 ms | -11.4% |
| ❌ | Simulation | decompress[u64, (1000, 16)] |
64.4 µs | 72.6 µs | -11.3% |
| ⚡ | Simulation | cold_misaligned[(64, 256)] |
5.2 ms | 4.4 ms | +19.49% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/generator (2f94580) with develop (86e9710)2
Footnotes
-
89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(dc8df2e) during the generation of this report, so 86e9710 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Do not require lists and instead accept python generators as an argument for
usability when creating multi child expressions