Skip to content

Expression constructors in python accept generators as an argument - #9410

Merged
robert3005 merged 1 commit into
developfrom
rk/generator
Aug 14, 2026
Merged

Expression constructors in python accept generators as an argument#9410
robert3005 merged 1 commit into
developfrom
rk/generator

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Do not require lists and instead accept python generators as an argument for
usability when creating multi child expressions

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/feature A new feature label Aug 14, 2026
@robert3005
robert3005 enabled auto-merge (squash) August 14, 2026 12:37
@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 7.72%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 1990 untouched benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (10000, 4)] 310.2 µs 401.6 µs -22.76%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=16] 1 ms 1.2 ms -11.4%
Simulation decompress[u64, (1000, 16)] 64.4 µs 72.6 µs -11.3%
Simulation cold_misaligned[(64, 256)] 5.2 ms 4.4 ms +19.49%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/generator (2f94580) with develop (86e9710)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (dc8df2e) during the generation of this report, so 86e9710 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005
robert3005 merged commit 15c73f3 into develop Aug 14, 2026
95 of 97 checks passed
@robert3005
robert3005 deleted the rk/generator branch August 14, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants