Skip to content

Array VTables Follow Up#7276

Draft
gatesn wants to merge 8 commits intodevelopfrom
ngates/vtable-cleanup
Draft

Array VTables Follow Up#7276
gatesn wants to merge 8 commits intodevelopfrom
ngates/vtable-cleanup

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Apr 3, 2026

This PR follows #7215

gatesn added 8 commits April 2, 2026 16:24
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added changelog/chore A trivial change changelog/break A breaking API change and removed changelog/chore A trivial change labels Apr 3, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will degrade performance by 21.85%

⚡ 4 improved benchmarks
❌ 9 regressed benchmarks
✅ 1109 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i64, 32768] 231.5 µs 179.9 µs +28.69%
Simulation new_alp_prim_test_between[f64, 2048] 64 µs 75.8 µs -15.6%
Simulation new_bp_prim_test_between[i32, 32768] 138.8 µs 159.2 µs -12.79%
Simulation new_bp_prim_test_between[i64, 16384] 109.6 µs 140.2 µs -21.85%
Simulation new_bp_prim_test_between[i64, 2048] 54.7 µs 65 µs -15.88%
Simulation new_bp_prim_test_between[i32, 16384] 93.1 µs 105.2 µs -11.44%
Simulation patched_take_10k_first_chunk_only 329.4 µs 273.9 µs +20.23%
Simulation take_10k_random 192 µs 239.9 µs -19.95%
Simulation take_10k_contiguous 269.8 µs 303.8 µs -11.19%
Simulation take_10_contiguous 28.7 µs 26 µs +10.39%
Simulation rebuild_naive 129.4 µs 117.2 µs +10.43%
Simulation decompress_rd[f32, (10000, 0.1)] 82.5 µs 93.2 µs -11.4%
Simulation decompress_rd[f32, (10000, 0.01)] 82.3 µs 93.2 µs -11.63%

Comparing ngates/vtable-cleanup (af6da6d) with develop (02b0949)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant