Add comment showing change in benchmark file sizes#7264
Open
Add comment showing change in benchmark file sizes#7264
Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
github-actions
bot
removed
the
action/benchmark-sql
a10y
changed the title
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.023x ➖ datafusion / vortex-file-compressed (1.023x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.994x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.995x ➖, 0↑ 0↓)
datafusion / parquet (1.026x ➖, 0↑ 4↓)
datafusion / arrow (0.997x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.008x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.995x ➖, 0↑ 0↓)
duckdb / parquet (0.979x ➖, 5↑ 2↓)
duckdb / duckdb (1.014x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: PolarSignals ProfilingNo baseline file sizes available yet. |
Contributor
File Sizes: TPC-H SF=1 on NVMENo baseline file sizes available yet. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.860x ✅, 6↑ 0↓)
datafusion / vortex-compact (0.936x ➖, 1↑ 0↓)
datafusion / parquet (0.893x ✅, 5↑ 0↓)
duckdb / vortex-file-compressed (0.903x ➖, 5↑ 0↓)
duckdb / vortex-compact (0.928x ➖, 2↑ 0↓)
duckdb / parquet (0.916x ➖, 3↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo baseline file sizes available yet. |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.844x ✅, 97↑ 0↓)
datafusion / vortex-compact (0.893x ✅, 66↑ 0↓)
datafusion / parquet (0.874x ✅, 78↑ 0↓)
duckdb / vortex-file-compressed (1.028x ➖, 0↑ 6↓)
duckdb / vortex-compact (1.031x ➖, 1↑ 3↓)
duckdb / parquet (1.009x ➖, 0↑ 1↓)
duckdb / duckdb (1.013x ➖, 1↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo baseline file sizes available yet. |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.998x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
datafusion / arrow (0.995x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.005x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.000x ➖, 0↑ 0↓)
duckdb / parquet (0.994x ➖, 1↑ 0↓)
duckdb / duckdb (0.999x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo baseline file sizes available yet. |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.904x ➖, 19↑ 0↓)
datafusion / parquet (0.909x ➖, 15↑ 0↓)
duckdb / vortex-file-compressed (0.895x ✅, 21↑ 0↓)
duckdb / parquet (0.932x ➖, 4↑ 0↓)
duckdb / duckdb (0.982x ➖, 3↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.022x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.826x ➖, 2↑ 0↓)
datafusion / parquet (0.998x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.059x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.016x ➖, 0↑ 0↓)
duckdb / parquet (1.078x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on S3No baseline file sizes available yet. |
Contributor
File Sizes: FineWeb S3No baseline file sizes available yet. |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
added
changelog/ci
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Contributor
|
Thoughts on having a single file per benchmark (I think we should move other benchmarks in that direction too?) |
Contributor
File Sizes: Clickbench on NVMENo baseline file sizes available yet. |
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.189x ➖, 1↑ 7↓)
datafusion / vortex-compact (0.979x ➖, 2↑ 3↓)
datafusion / parquet (0.806x ➖, 8↑ 2↓)
duckdb / vortex-file-compressed (1.010x ➖, 1↑ 0↓)
duckdb / vortex-compact (1.034x ➖, 0↑ 0↓)
duckdb / parquet (0.998x ➖, 1↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on S3No baseline file sizes available yet. |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
added
changelog/skip
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Contributor
Author
|
@joseph-isaacs I don't really care, I was just trying to match what we have today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional comment as part of the PR benchmarks reporting that shows the change in size of SQL benchmark files after applying the diff from the PR.
Only applies to vortex and vortex-compact
Similar to our other benchmarks, tracks state over time via a GZipped JSON file stored in S3 bucket.