Perform validation and null view replacement in two passes - #10148
robert3005 wants to merge 2 commits into
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will regress 3 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | mul_u64_nonnull_neon |
29.6 µs | 39.7 µs | -25.46% |
| ❌ | WallTime | multiply_shapes_neon[(32768, PerRowPerRow)] |
33.3 µs | 38.6 µs | -13.94% |
| ❌ | WallTime | mul_i64_nonnull_neon |
33.5 µs | 38.6 µs | -13.43% |
| ⚡ | Simulation | all_valid_exclusive[65536] |
6.9 ms | 3.9 ms | +73.92% |
| ⚡ | Simulation | all_valid_exclusive[4096] |
438.3 µs | 256.9 µs | +70.62% |
| ⚡ | WallTime | dict_canonicalize_gt_u8_neon[1000000] |
547 µs | 488 µs | +12.09% |
| ⚡ | WallTime | scalar_subtract_neon |
13.9 µs | 12.6 µs | +10.81% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/validate (80d9731) with develop (a96e0a8)
Footnotes
-
503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
When validating VarBinViewArray first validate the buffers and inline strings
and only later iterate nulls and replace them with sentinel values