Skip to content

Perform validation and null view replacement in two passes - #10148

Open
robert3005 wants to merge 2 commits into
developfrom
rk/validate
Open

robert3005 wants to merge 2 commits into
developfrom
rk/validate

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

When validating VarBinViewArray first validate the buffers and inline strings
and only later iterate nulls and replace them with sentinel values

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 2055 untouched benchmarks
⏩ 503 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime mul_u64_nonnull_neon 29.6 µs 39.7 µs -25.46%
❌ WallTime multiply_shapes_neon[(32768, PerRowPerRow)] 33.3 µs 38.6 µs -13.94%
❌ WallTime mul_i64_nonnull_neon 33.5 µs 38.6 µs -13.43%
⚡ Simulation all_valid_exclusive[65536] 6.9 ms 3.9 ms +73.92%
⚡ Simulation all_valid_exclusive[4096] 438.3 µs 256.9 µs +70.62%
⚡ WallTime dict_canonicalize_gt_u8_neon[1000000] 547 µs 488 µs +12.09%
⚡ WallTime scalar_subtract_neon 13.9 µs 12.6 µs +10.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/validate (80d9731) with develop (a96e0a8)

Open in CodSpeed

Footnotes

  1. 503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/performance A performance improvement label Sep 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant