Repository navigation
fix(tracing): record standard streaming TTFT telemetry - #1194
Merged
Merged
Conversation
Add the actual SDK streaming flag and seconds-valued TTFT to per-request LLM spans, and record the existing TTFT histogram once at first output. Preserve legacy timestamps, omit absent observations, and keep metrics independent of usage and trace sampling. Add regression coverage and synchronize bilingual tracing documentation. Validation after rebase: 156 affected tests and pre-commit pass. Default regression: 8044 pass; one pre-existing Markdown MIME test still fails. Change-Id: If7113949389b8c5707feb20b8c67479700f0f19b
Represent HTTP, Runner and SDK boundaries with native span timestamps. Remove custom timing attributes and first-token events without aliases. Use standard error status and bounded error types, and retain once-per- request TTFT attributes and histogram recording. Update bilingual documentation and regression tests. After synchronization, 294 affected tests and pre-commit pass. Full regression has 8053 passing cases and the previously reproduced unrelated Markdown MIME failure. Change-Id: I3b4f2eacb84bb1c378915cb244e68497190738cd
Remove prd-spec and specs; keep plans and verification summaries in conversation or PR descriptions. Require an explicit user request before creating standalone design/spec documents. Change-Id: Ibabda377bee6fc64b844dfe4164febb4fa1d6cd5 Validation: all pre-commit hooks passed; YAML secret scanner unit tests passed (4 tests). Documentation and workflow guidance only; no runtime code or public API changes.
yaozheng-fang
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the actual SDK streaming flag and seconds-valued TTFT to per-request LLM spans, and record the existing TTFT histogram once at first output. Preserve legacy timestamps, omit absent observations, and keep metrics independent of usage and trace sampling.
Add regression coverage and synchronize bilingual tracing documentation. Validation after rebase: 156 affected tests and pre-commit pass. Default regression: 8044 pass; one pre-existing Markdown MIME test still fails.
Change-Id: If7113949389b8c5707feb20b8c67479700f0f19b