fix(workspace): support dot-relative workspace patterns#547
Open
liangmiQwQ wants to merge 4 commits into
Open
Conversation
4 tasks
Co-authored-by: GPT-5 Codex <codex@openai.com>
liangmiQwQ
force-pushed
the
liang/codex/fix-workspace-dot-slash
branch
from
July 19, 2026 06:27
c990385 to
fd4dcb2
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
liangmiQwQ
marked this pull request as ready for review
July 19, 2026 06:41
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
wan9chi
reviewed
Jul 20, 2026
liangmiQwQ
marked this pull request as draft
July 20, 2026 09:35
liangmiQwQ
force-pushed
the
liang/codex/fix-workspace-dot-slash
branch
from
July 20, 2026 09:37
79e1587 to
fcac813
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
liangmiQwQ
marked this pull request as ready for review
July 20, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes voidzero-dev/vite-plus#2201
Motivation
npm accepts workspace patterns that start with
./, but Vite Task passed those patterns directly to the glob walker and failed to discover matching packages.This PR strips the current-directory prefix before matching while preserving optional negation. The existing npm workspace graph test now covers the reported
./packages/*and./apps/*forms.🤖 Generated with Codex