feat(cli): add --quiet to vp check - #2593
Open
RSS1102 wants to merge 5 commits into
Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
RSS1102
force-pushed
the
rss1102/issue-2588-quiet-check
branch
from
September 2, 2026 01:52
3e4bdeb to
d99aadd
Compare
RSS1102
marked this pull request as ready for review
September 3, 2026 02:29
fengmk2
reviewed
Sep 3, 2026
| [[case]] | ||
| name = "check_fix_lint_warn" | ||
| vp = "local" | ||
| env = { VP_NODE_VERSION = "22.18.0" } |
Member
There was a problem hiding this comment.
Why is it necessary to add this environment variable? Is there a reason that causes the tests to be unstable?
fengmk2
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--quietsupport tovp checkand forward it to the Oxlint phaseCloses #2588
Example
With one lint error and one warning,
vp check --quietprints only the error diagnostic while preserving both counts in the unified summary:The
no-consolewarning diagnostic is omitted, matchingvp lint --quiet, while the warning remains visible in the aggregate count.Testing
cargo test -p vite-plus-cli check::analysis::testscargo test -p vp_cli_snapshots -- check_lint_warn::check_lint_warncargo test -p vp_cli_snapshots -- check_lint_fail::check_lint_failcargo test -p vp_cli_snapshots -- command_check_help::command_check_helpcargo clippy -p vite-plus-cli --all-targets --no-default-features -- --deny warningsvp fmt --check packages/cli/src/help.ts docs/guide/check.mdcargo fmt --all -- --check