-
Notifications
You must be signed in to change notification settings - Fork 256
feat: ship a Renovate preset and dependency-bot docs for lockstep updates #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "description": "Shared Renovate preset for Vite+ projects: keeps vite-plus, the vite catalog alias (@voidzero-dev/vite-plus-core), and the pinned vitest family in one grouped update. Consume with \"extends\": [\"github>voidzero-dev/vite-plus\"].", | ||
| "packageRules": [ | ||
| { | ||
| "description": "Explicit minimumReleaseAge and schedule give every member one eligibility policy, so another preset cannot hold one member back and split the group.", | ||
| "groupName": "vite+", | ||
| "matchPackageNames": ["vite-plus", "@voidzero-dev/vite-plus-*", "vitest", "@vitest/*"], | ||
| "minimumReleaseAge": "1 day", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO, users of this preset may be a bit surprised by this (especially if it differs to their existing settings)
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's why I haven't continued with this PR either, because I do not want to modify the Renovate configuration. I'm wondering if renovatebot/renovate#45630 this Renovate PR can solve the Vite+ version upgrade issue, then I can remove this preset. 💌 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's the hope 🤞🏼 We do also have renovatebot/renovate#45631 for the Renovate config side, so y'all don't need to maintain that yourselves |
||
| "schedule": ["at any time"] | ||
| } | ||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd be happy having a "monorepo preset" for these packages in upstream Renovate, if that'd be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renovatebot/renovate#45631