chore(ci): ensure no file changes after build-upstream step#1563
Merged
Conversation
Prevents unexpected file modifications from going unnoticed. Refs #1305 (comment)
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Interception successful |
Upstream rolldown_devtools no longer depends on dashmap; the stale entry was previously rewritten on every build (caught by the new post-build git status check in this PR).
jong-kyung
approved these changes
May 13, 2026
cpojer
approved these changes
May 13, 2026
branchseer
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git status --porcelaincheck immediately after theBuild with upstreamstep in thecli-e2e-testjobgit status+git diffoutput if the build mutates any tracked filesx86_64-unknown-linux-gnuonlyRefs #1305 (comment)
Test plan
build-upstream)