Skip to content

assimp_qt_viewer: remove package - #63240

Open
hosaka wants to merge 1 commit into
void-linux:masterfrom
hosaka:assimp
Open

hosaka wants to merge 1 commit into
void-linux:masterfrom
hosaka:assimp

Conversation

@hosaka

@hosaka hosaka commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

I'd like to propose alternative approach to #60598.

Removing the assimp_qt_viewer first will make submitting assimp version bump pass the CI with no failures and will remove the qt_viewer for users that run xbps-install -Su, making it easier to update the libassimp shlib version.

I have prepared a template similar to #60598 for assimp itself, which would follow this PR: assimp turns into a metapackage with libassimp and libassimp-devel. Also enabling tests and actually running them.

if [ "$XBPS_CHECK_PKGS" ]; then
	configure_args+=" -DASSIMP_BUILD_TESTS=ON"
else
	configure_args+=" -DASSIMP_BUILD_TESTS=OFF"
fi

do_check() {
	cd build
	./bin/unit
}

Right now the tests are compiled by default, but never run.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant