uosc: include 'Updater.lua'#60523
Open
dogknowsnx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
We intentionally do not ship
uosc's utility binary which enables checking for updates for manual installations (upstream provides an install-script). Applyingmpv's defaultinput.confdoes not hide the "Update uosc" item from the "Utils" submenu, and clicking on it w/oUpdater.luapresent will crash the UI instead of simply reporting an error about the missing binary. I've always used a custominput.confin my$HOME, that's why this kind of crash never occurred to me before.cc @Duncaen