use config seperate librs/infra string functions#355
Closed
zhanghe-vivo wants to merge 0 commit intovivoblueos:mainfrom
Closed
use config seperate librs/infra string functions#355zhanghe-vivo wants to merge 0 commit intovivoblueos:mainfrom
zhanghe-vivo wants to merge 0 commit intovivoblueos:mainfrom
Conversation
| deps = shared_deps | ||
| } | ||
|
|
||
| config("disable_string_exports") { |
Contributor
There was a problem hiding this comment.
Is it possible to set in Kconfig?
|
|
||
| // used by core/src/slice/cmp.rs | ||
| /// See <https://pubs.opengroup.org/onlinepubs/9799919799/functions/memcmp.html>. | ||
| #[cfg(not(disable_infra_c_string_exports))] |
Contributor
There was a problem hiding this comment.
This function is already weak-linked. Why do we still need to isolate it based on cfg?
Contributor
Author
There was a problem hiding this comment.
i can try to let all of them use weak-linked attributes, let linker choose one(should be order , maybe choose the first occurence）, therefore, also don't need change these build.gn files
zhanghe-vivo
force-pushed
the
zhanghe_missing_sd
branch
from
127fe41 to
725cd0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add some missing string functions, but some of them reuse same #[no_demagle] posix implementation , they conflict with infra implementations, now add an config object in GN as an solution
vivoblueos/librs#28