refactor(rsc): use Vite ESTree types - #1347
Draft
hi-ogawa wants to merge 1 commit into
Draft
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
marked this pull request as draft
July 29, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESTreenamespaceestree-walkeronce so its classic ESTree declarations do not leak into transform code@types/estreedependency, workspace override, and@oxc-project/typestsconfig remapping@types/estreeremains a transitive dependency ofestree-walker; this PR only removes RSC’s direct dependency and type workaround.Tests
pnpm -C packages/plugin-rsc buildpnpm -C packages/plugin-rsc tscpnpm -C packages/plugin-rsc test --run