Skip to content

fix(core): disable shortcuts for path-dependent commands - #578

Draft
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/editor-finder-shortcuts
Draft

SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/editor-finder-shortcuts

Conversation

@SaKaNa-Y

Copy link
Copy Markdown
Collaborator

Related to #571.

Open in Editor and Open in Finder require a path, but keyboard shortcuts invoke commands without arguments. Both commands are already hidden from the palette, yet users can still bind them in shortcut settings.

Set allowShortcuts: false on both registrations. With the upstream Hub change, this removes their shortcut settings and ignores previously saved bindings while preserving explicit calls that supply a path.

This draft depends on devframes/devframe#395. Before merging, that change must be released and the Devframe/Hub dependencies updated to a version containing it. The current dependency versions and lockfile are unchanged.

Verification:

  • pnpm lint passed.
  • pnpm test --run passed: 324 tests, 2 skipped.
  • pnpm build passed.
  • pnpm typecheck fails because the current Hub types do not yet expose allowShortcuts; it must be rerun after the dependency update. The upstream PR covers shortcut dispatch and settings behavior.

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@578

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@578

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@578

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@578

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@578

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@578

commit: 94a16d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant