docs: add devframe references and guard docs build in CI - #577
Merged
Merged
Conversation
Surface Devframe/hub-origin features (rpc, shared state, json-render, diagnostics, when clauses, commands, docks) with kit-first pointers to devfra.me, keeping the Vite DevTools docs focused on the Vite path. Add a docs-build step to CI so a broken docs site fails PRs instead of letting Netlify keep serving the last good (stale) deploy. fixes #562
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The deployed docs site was serving stale content (0.4.12), notably a Getting Started guide that still advised
visibility: 'passive'— an option renamed toembeddedVisibilityin #531. The repo docs were already current, so the site was stale because a brokendocs:buildlets Netlify keep serving the last successful deploy. CI builds the packages but never the docs site, so a docs-only breakage slips through unnoticed.This PR:
docs:buildstep to thelintjob (which already builds packages) so a broken docs site fails PRs instead of silently going stale. Merging this also re-triggers a fresh Netlify deploy with current content. Edited in bothsrc/ci.ymland the generatedci.ymlto keep actionspack output consistent.Linked Issues
fixes #562
Additional context
The Getting Started guide already uses the correct
embeddedVisibilityoption; no content change was needed there. The core fix is preventing the docs deploy from silently going stale again.This PR was created with the help of an agent.