feat: forward onTrusted from DevToolsConfig to the interactive auth handler - #575
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getAuthHandlerforwardedconfig.bannertocreateInteractiveAuthbut notonTrusted, andDevToolsConfighad noonTrustedfield. This addsonTrusted?: CreateInteractiveAuthOptions['onTrusted']toDevToolsConfigand forwards it ingetAuthHandler, mirroring howbanneris handled — skipped in the implicit build-mode capability-token branch, where the banner is already silenced and trust comes from the capability token rather than a code exchange.Linked Issues
Closes #574
Additional context
This is the last unticked link in the chain from nuxt/devtools#1080: devframe 0.10.0 already ships
onTrustedoncreateInteractiveAuth(devframes/devframe#291), and this repo is already pinned to that version.This PR was created with the help of an agent.