fix(core): forward loading to json-render Button's underlying BaseButton - #497
Open
dvcolomban wants to merge 2 commits into
Open
fix(core): forward loading to json-render Button's underlying BaseButton#497dvcolomban wants to merge 2 commits into
dvcolomban wants to merge 2 commits into
Conversation
JrButton's props/setup never read element.props.loading, so a spec-driven Button with loading: true silently dropped it — only disabled/icon reached the rendered button. BaseButton already fully supports loading (spinner in place of the icon slot); this just wires the existing prop through.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JrButton(json-render'sButtoncatalog element) never readelement.props.loading, so a spec-driven Button withloading: truesilently dropped it — onlydisabled/iconactually reached the rendered button.BaseButton(display/Button.vue) already fully supportsloading(renders its spinner in place of the icon slot), it just wasn't wired through.loading?: booleantoButtonProps, destructures it, and forwards it toBaseButton.loadingexample to theJsonRender.stories.tsGallery story (button staysicon-set to demonstrate thatloadingtakes precedence and swaps in the spinner).Test plan
pnpm run typecheck(vue-tsc -b)pnpm eslinton the two changed filespnpm run build:js+ client build inpackages/coreJsonRender/Gallery) — the addedDeploying…button shows the spinner instead of its icon