fix(core): fix devtools asset routing under /__devtools#353
Merged
Conversation
JianJroh
force-pushed
the
fix/h3-mount-trailing-slash
branch
from
c628ecb to
b69850b
Compare
JianJroh
force-pushed
the
fix/h3-mount-trailing-slash
branch
from
b69850b to
711d857
Compare
commit: |
Member
|
Seems be related to #354 |
webfansplz
changed the title
/__devtools
webfansplz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After running
vite-devtools(e.g.pnpm -F @vitejs/devtools play:build), opening/__devtools/loads the SPA shell but every asset under/__devtools/assets/*returns 404.Cause
PR #346 (h3 v1 → v2 migration) changed the sub-app mount from
app.use(DEVTOOLS_MOUNT_PATH, h3.handler)toapp.use(DEVTOOLS_MOUNT_PATH, h3). With anH3instance,app.useroutes throughH3.mount(base, subApp), whoseinternal matcher assumes
basehas no trailing slash:Additional context
https://github.com/h3js/h3/blob/84244b49b84e6ce6260d6b3a3590409e0d525fab/src/h3.ts#L129-L140