fix(mail): avoid $orderby together with $search (Graph rejects it)#12
Open
okuegow wants to merge 1 commit into
Open
fix(mail): avoid $orderby together with $search (Graph rejects it)#12okuegow wants to merge 1 commit into
okuegow wants to merge 1 commit into
Conversation
Microsoft Graph returns "SearchWithOrderBy: The query parameter '$orderby' is not supported with '$search'" for /me/messages, so every `mog mail search <query>` failed outright. Extract query building into buildMailSearchQuery and only apply $orderby when not searching; listing (`*`/empty/whitespace) keeps date sorting. Escape backslash and double quote in the $search phrase so terms like `foo" bar` or `C:\Temp` produce a valid query. Adds unit tests for the query builder (incl. escaping/whitespace) and a Run-level test asserting the $search/$orderby split via the mock client. Fixes visionik#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mog mail search(andmail list, which delegates to it) sent$orderbytogether with$search. Microsoft Graph rejects that combination for/me/messages(SearchWithOrderBy: The query parameter '$orderby' is not supported with '$search'), so every text search (mog mail search <term>) failed outright; only*/ listing worked.Fix
buildMailSearchQueryand apply$orderbyonly when not doing a$search. Listing (*, empty, or whitespace-only) keeps date sorting.\and"inside the$searchphrase so terms likefoo" barorC:\Tempdon't produce a broken/altered query.Tests
buildMailSearchQueryunit tests: search vs listing, escaping, whitespace.Run-level test asserting via the mock client that a real query sets$searchand no$orderby, and*does the reverse.go build ./...,go vet ./...,go test ./...pass.Fixes #11