Repository navigation
fix(website): classify source badges by URL hostname - #3388
Closed
OKAN-SOFTWARE wants to merge 1 commit into
Closed
OKAN-SOFTWARE wants to merge 1 commit into
OKAN-SOFTWARE wants to merge 1 commit into
Conversation
Compare URL hostnames against known source domains instead of searching for domain text anywhere in an untrusted URL. Cover lookalike hosts, userinfo, query/path text, subdomains and trailing-dot hostnames with regression tests.
Owner
|
Thanks, but I don't think we need this. Every URL in README.md is reviewed before it's merged, so a lookalike hostname like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Previously,
detect_source_type()looked for known domain names anywhere in the URL. For example,https://docs.python.org.lookalike.example/...was classified asStdlib, even though it was an unrelated site. A similar issue affected GitHub, GitLab, and Bitbucket badges.Validation
uv run pytest website/tests/ -q— 177 passeduv run ruff check .— passeduv run ty check website— passeduv run python website/build.py— passedgit diff --check— passedChanges are scoped to
website/build.pyandwebsite/tests/test_build.py.