Skip to content

fix: ci issue due to mypy update on python3.11#166

Merged
vinitkumar merged 1 commit into
masterfrom
fix/ci-mypy-broken-test
Jan 3, 2023
Merged

fix: ci issue due to mypy update on python3.11#166
vinitkumar merged 1 commit into
masterfrom
fix/ci-mypy-broken-test

Conversation

@vinitkumar

@vinitkumar vinitkumar commented Jan 3, 2023

Copy link
Copy Markdown
Owner
json2xml/dicttoxml.py:250: error: Function "Type[Number]" could always be 
true in boolean context  [truthy-function]

Latest mypy identifies this as problematic, so cleaning this up condition.

@codecov

codecov Bot commented Jan 3, 2023

Copy link
Copy Markdown

Codecov Report

Base: 94.02% // Head: 94.02% // No change to project coverage 👍

Coverage data is based on head (e691e58) compared to base (63aa3b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files           6        6           
  Lines         536      536           
=======================================
  Hits          504      504           
  Misses         32       32           
Impacted Files Coverage Δ
json2xml/dicttoxml.py 89.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinitkumar vinitkumar merged commit 18b1f16 into master Jan 3, 2023
@vinitkumar vinitkumar deleted the fix/ci-mypy-broken-test branch February 21, 2025 12:03
@vinitkumar vinitkumar restored the fix/ci-mypy-broken-test branch June 14, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant