feat: make deps more flexible#158
Merged
Merged
Conversation
Codecov ReportBase: 94.04% // Head: 94.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 94.04% 94.02% -0.02%
==========================================
Files 6 6
Lines 537 536 -1
==========================================
- Hits 505 504 -1
Misses 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 4 commits
October 16, 2022 13:34
v0.12.0..v0.13.0 has changed the type of what is returned. ```diff -from collections import OrderedDict +_dict = dict +import platform ``` Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl> Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the deps not strict, as it reduces the usefulness of the library and causes problems to the project using them.
xmltodictlibrary changed the type of what is returned.This change is requested by #157 where he is correct in suggesting that the tight requirements may cause issues with projects using this library.