Skip to content

fix: use SystemRandom as a secure way for generating Random Integers #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinitkumar merged 3 commits into from
Sep 27, 2022
Merged

fix: use SystemRandom as a secure way for generating Random Integers #156

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac203d0
fix: use SystemRandom as a secure way for generating Random Integers
Sep 24, 2022
9f22895
fix: move all module level imports to the top
Sep 25, 2022
aa7b3e8
fix: isort issues
Sep 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions json2xml/dicttoxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,19 @@
import numbers
import os
from collections.abc import Callable, Sequence
from random import randint
from random import SystemRandom
from typing import Any, Dict, Union

from defusedxml.minidom import parseString

safe_random = SystemRandom()
DEBUGMODE = os.getenv("DEBUGMODE", False) # pragma: no cover
LOG = logging.getLogger("dicttoxml") # pragma: no cover


def make_id(element: str, start: int = 100000, end: int = 999999) -> str:
"""Returns a random integer"""
return f"{element}_{randint(start, end)}"
return f"{element}_{safe_random.randint(start, end)}"


def get_unique_id(element: str) -> str:
Expand Down
Loading