Feat/unittest to pytest#149
Merged
Merged
Conversation
added 3 commits
July 22, 2022 22:59
We have a ids variable that stores a list of unique ids. The issue is that it is globally shared and can mutate across tests. This caused a failure in one of the test that shouldn't contain id but it does in this case. When the global ids is removed and put into the function where it is used and the reference of ids in other functions properly instantiated, we can see that the crash is gone. - Github Issue: #150 Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl> Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 93.55% 93.95% +0.39%
==========================================
Files 6 6
Lines 512 529 +17
==========================================
+ Hits 479 497 +18
+ Misses 33 32 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.