Feat/remove logging by default#131
Conversation
Library shouldn't be emitting logs by default and not pollute the consumers. Hence, we put the LOGS behind a flag. To see the library's logs, set DEBUGMODE=True in environment for the logs to work. DEBUGMODE is a fairly unique env variable so should do do the trick. - Github Issue: #130 Reported-by: https://github.com/ricciarellif Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl> Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 91.28% 92.19% +0.91%
==========================================
Files 5 5
Lines 459 423 -36
==========================================
- Hits 419 390 -29
+ Misses 40 33 -7
Continue to review full report at Codecov.
|
|
FYI, I did not make any branch of your project: I've done a pip install and used the library with an import. |
|
@ricciarellif Alright, maybe I was not clear. Anyways. I did fix the issue and did release on https://pypi.org/project/json2xml/3.19.0rc1/ So please install from pip like this:
Please mind that this is a release candidate and not the final release, so please don't use this version in production yet. |
Disable logging in the consumers by default.