Skip to content

feat: add types#125

Merged
vinitkumar merged 9 commits into
masterfrom
feat/add-type-annotation
Apr 30, 2022
Merged

feat: add types#125
vinitkumar merged 9 commits into
masterfrom
feat/add-type-annotation

Conversation

@vinitkumar

@vinitkumar vinitkumar commented Apr 30, 2022

Copy link
Copy Markdown
Owner

Add 100% type coverage to the module for easy refactors.

@codecov-commenter

codecov-commenter commented Apr 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #125 (b195dad) into master (e670976) will increase coverage by 2.16%.
The diff coverage is 92.39%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   89.11%   91.28%   +2.16%     
==========================================
  Files           5        5              
  Lines         441      459      +18     
==========================================
+ Hits          393      419      +26     
+ Misses         48       40       -8     
Impacted Files Coverage Δ
json2xml/dicttoxml.py 85.84% <90.14%> (+3.85%) ⬆️
tests/test_json2xml.py 99.39% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e670976...b195dad. Read the comment docs.

@vinitkumar vinitkumar merged commit d4d923b into master Apr 30, 2022
@vinitkumar vinitkumar deleted the feat/add-type-annotation branch April 30, 2022 20:46
@vinitkumar vinitkumar restored the feat/add-type-annotation branch June 14, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants