fix: return correct xml type for bool#119
Merged
Merged
Conversation
As discussed nicely in the issue #118, the correct bool value is never returned as the bool is also a subtype of numbers.Number and int. Here, hence, the check for bool is done first because while the above condition might be true for bool, no other type can say the same for bool check. i.e. Numbers won't be an instance of bool and so would be int. A test is added to guard against the future regression on this as well. - Github Issue: Resolves #118 Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl> Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed nicely in the issue
#118, the correct bool
value is never returned as the bool is also a subtype of numbers.Number
and int.
Here, hence, the check for bool is done first because while the above
condition might be true for bool, no other type can say the same for
bool check. i.e. Numbers won't be an instance of bool and so would be
int.
A test is added to guard against the future regression on this as well.
Authored-by: Vinit Kumar vinit.kumar@kidskonnect.nl
Signed-off-by: Vinit Kumar vinit.kumar@kidskonnect.nl