improvments on dicttoxml#117
Closed
DirkRichter wants to merge 1 commit into
Closed
Conversation
DirkRichter
commented
Apr 13, 2022
DirkRichter
commented
Contributor
- support of namespaces
- moving full object serialization into loglevel debug (reduce cpu + out of mem on large objects)
- more control parameters on xml generation: allow custom xml attributes via @attr + optionally omit encapsulating xml-nodes via @Flat
Owner
|
@DirkRichter Thanks for the PR. I will look into it. Also, looks like not all the tests are passing. |
Owner
|
This branch didn't had the tests running because of an issue with CI, I cherry picked your commits into this another branch and made a PR. #120. Please look into the tests failure there and if possible fix the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.