The tool wrapper unconditionally passes filter_type=filter_type into … - #9
Open
ssteenhoek-dev wants to merge 1 commit into
Open
The tool wrapper unconditionally passes filter_type=filter_type into …#9ssteenhoek-dev wants to merge 1 commit into
ssteenhoek-dev wants to merge 1 commit into
Conversation
…the API client The tool wrapper unconditionally passes filter_type=filter_type into the API client — even when nothing was supplied and it's None — but the client method was never updated to accept that parameter at all. So this fails on every single call, with any arguments, until someone patches one side or the other (either drop the filter_type= pass-through in collector_tools.py, or add filter_type support to SumoLogicAPIClient.list_collectors()). Bottom line: list_collectors is not usable as-is — this is a genuine upstream defect, separate from everything we fixed today. Everything else (list_monitors, and by extension the connection itself) is confirmed working end to end. Worth filing alongside the pywin32 note for whoever owns this build, with the exact line numbers above so it's a two-minute fix rather than a re-investigation.
ssteenhoek-dev
commented
Jul 22, 2026
ssteenhoek-dev
left a comment
ssteenhoek-dev
left a comment
Author
There was a problem hiding this comment.
The tool wrapper unconditionally passes filter_type=filter_type into the API client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the API client
The tool wrapper unconditionally passes filter_type=filter_type into the API client — even when nothing was supplied and it's None — but the client method was never updated to accept that parameter at all. So this fails on every single call, with any arguments, until someone patches one side or the other (either drop the filter_type= pass-through in collector_tools.py, or add filter_type support to SumoLogicAPIClient.list_collectors()).
Bottom line: list_collectors is not usable as-is — this is a genuine upstream defect, separate from everything we fixed today. Everything else (list_monitors, and by extension the connection itself) is confirmed working end to end. Worth filing alongside the pywin32 note for whoever owns this build, with the exact line numbers above so it's a two-minute fix rather than a re-investigation.