Add textViewContainerInset as new parameter#500
Open
ngunngun wants to merge 5 commits intovikmeup:masterfrom
Open
Add textViewContainerInset as new parameter#500ngunngun wants to merge 5 commits intovikmeup:masterfrom
ngunngun wants to merge 5 commits intovikmeup:masterfrom
Conversation
added 5 commits
October 27, 2022 10:18
Collaborator
|
We probably shouldn't set it to .zero by default. Either don't change it by default, or set it to (8, 0, 8, 0) - the default that Apple uses, see I wonder why the original author set it to zero? To make it more compact? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some languages, there are an upper character that was located above the alphabet. If we use textViewContainerInset as zero, the above character would be missing. In some word that the character was missing, the meaning also changed.