Skip to content

Fix: Correct search window calculation in ApplyXMLMixin #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicsanity623 merged 1 commit into from
May 28, 2026
Merged

Fix: Correct search window calculation in ApplyXMLMixin #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pyob/xml_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def _attempt_line_by_line_match(

replace_lines = replace.split("\n")
code_lines = source.splitlines()
for i in range(len(code_lines) - len(search_lines_stripped) + 1):
for i in range(len(code_lines) - len(search_lines) + 1):
match = True
for j, sline in enumerate(search_lines_stripped):
if sline not in code_lines[i + j].strip():
Expand All @@ -276,13 +276,13 @@ def _attempt_line_by_line_match(
if match:
# Apply indentation fix to replacement lines
fixed_replace = self._fix_replace_indentation(
"\n".join(code_lines[i : i + len(search_lines_stripped)]),
"\n".join(code_lines[i : i + len(search_lines)]),
"\n".join(replace_lines),
)
new_code_lines = (
code_lines[:i]
+ fixed_replace.splitlines()
+ code_lines[i + len(search_lines_stripped) :]
+ code_lines[i + len(search_lines) :]
)
new_code = "\n".join(new_code_lines)
if not new_code.endswith("\n") and source.endswith("\n"):
Expand Down
Loading