Skip to content

Refactor: Add type hinting and docstrings to EntranceController methods #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicsanity623 merged 1 commit into from
May 28, 2026
Merged

Refactor: Add type hinting and docstrings to EntranceController methods #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pyob/entrance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ def _run_git_command(self, cmd: list[str]) -> bool:
def detect_symbolic_ripples(
self, old: str, new: str, source_file: str
) -> list[str]:
diff = list(difflib.unified_diff(old.splitlines(), new.splitlines()))
"""Detects files impacted by symbolic changes."""
diff: list[str] = list(difflib.unified_diff(old.splitlines(), new.splitlines()))
changed_text = "\n".join(
[line for line in diff if line.startswith("+") or line.startswith("-")]
)
Expand All @@ -466,7 +467,10 @@ def detect_symbolic_ripples(
impacted_files.append(target_file)
return list(set(impacted_files))

def update_analysis_for_single_file(self, target_abs_path: str, rel_path: str):
def update_analysis_for_single_file(
self, target_abs_path: str, rel_path: str
) -> None:
"""Updates the analysis markdown for a specific file."""
if not os.path.exists(self.analysis_path):
return
with open(target_abs_path, "r", encoding="utf-8", errors="ignore") as f:
Expand Down
Loading