[world-local] Fix package info stored in data dir showing the wrong version #718
+160
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: af835df The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (17 failed)mongodb (1 failed):
redis (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
TooTallNate
reviewed
Jan 7, 2026
packages/world-local/src/init.ts
Outdated
|
|
||
| /** | ||
| * Get the directory path for this module. | ||
| * Works in both ESM (direct usage) and bundled CJS contexts. |
Member
There was a problem hiding this comment.
I'm not understanding how this would work in CJS contexts (also why would it need to?)
Member
Author
There was a problem hiding this comment.
It doesn't, the comment is wrong, whoops
TooTallNate
reviewed
Jan 7, 2026
| * In bundled contexts where package.json cannot be read, | ||
| * returns 'bundled' as the version. | ||
| */ | ||
| export async function getPackageInfo(): Promise<PackageInfo> { |
Member
There was a problem hiding this comment.
I wonder if we could leverage require() instead? Not blocking though, I'm fine with this for now and we can see if it causes any real world issues. Just feels a bit brittle to me.
Member
Author
There was a problem hiding this comment.
I think this should overall be replaced by the version solution that's in Pranay's event sourcing PR. We could merge this first if we want, or scrap for re-doing it after Pranay's PR lands
VaguelySerious
commented
Jan 7, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| const currentVersion = parseVersion(PACKAGE_VERSION); | ||
| const packageInfo = await getPackageInfo(); | ||
| const currentVersion = parseVersion(packageInfo.version); |
Contributor
There was a problem hiding this comment.
initDataDir() crashes in bundled contexts when parseVersion() receives 'bundled' string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might now be irrelevant after changes in #621