Skip to content

[web-shared] Move error card to bottom of detail panel#2337

Open
mitul-s wants to merge 1 commit into
mainfrom
ms/error-card-placement
Open

[web-shared] Move error card to bottom of detail panel#2337
mitul-s wants to merge 1 commit into
mainfrom
ms/error-card-placement

Conversation

@mitul-s

@mitul-s mitul-s commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moves the Error detail card to the bottom of the entity detail panel (just above the events list) so it no longer shifts the input/output cards as data loads.
  • Only auto-expands the error card when the workflow run itself failed; step-level errors stay collapsed.
  • Hides the error card entirely for steps that completed after retrying (the attempt error is already visible in the events list). A step that failed terminally after exhausting retries still surfaces its error.

Test plan

  • Open a failed workflow run → error card shown and expanded at the bottom.
  • Open a step that succeeded after a retry → no error card; attempt error visible in events.
  • Open a step that failed terminally → error card shown (collapsed) at the bottom, below input/output.
  • Confirm no layout shift of input/output cards while details load.

Made with Cursor

Render the error card after input/output (just above the events list) so it
no longer shifts those cards on load. Only auto-expand it when the workflow
run itself failed, and hide it entirely for steps that completed after
retrying since the attempt error is already shown in the events list. A step
that failed terminally still surfaces its error.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s mitul-s requested a review from a team as a code owner June 10, 2026 20:58
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jun 10, 2026 9:02pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jun 10, 2026 9:02pm
example-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-astro-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-express-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-fastify-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-hono-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-nitro-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-nuxt-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workbench-vite-workflow Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Jun 10, 2026 9:02pm
workflow-swc-playground Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workflow-tarballs Ready Ready Preview, Comment Jun 10, 2026 9:02pm
workflow-web Ready Ready Preview, Comment Jun 10, 2026 9:02pm

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0c543b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant