fix: update minimatch to 3.1.5 to resolve security vulnerabilities#228
Conversation
Bumps minimatch from 3.1.2 to 3.1.5, the latest patch in the 3.x line. This resolves the following CVEs: - GHSA-3ppc-4f35-3m26 (ReDoS via repeated wildcards, high severity) - GHSA-7r86-cg39-jmmj (ReDoS via multiple non-adjacent GLOBSTAR segments, high severity) - GHSA-23c5-xmqv-rm74 (ReDoS via nested *() extglobs, high severity) Fixes vercel#206
|
This would be an alternative to #226 |
This is a better alternative imo, v10.2.4 is an aggressive update. 3.1.5 is within the 3.x family and contains the remediation. |
Note the comment in actions/toolkit#2306 from the package owner, where he talks about updating to v10 to move to a supported version. The repo maintainers will need to decide which way to go. Your PR would solve the immediate problem. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
AndyBitz
left a comment
There was a problem hiding this comment.
Thanks for opening the PR and reaching out to me!
I'll merge and publish this one instead of the upgrade to 10.x to get it out faster, as the upgrade to 10.x would warrant a major release and it's better to keep this security fix smaller.
We can revisit the upgrade to 10.x afterwards.
|
This has merged into the |
|
@MikeMcC399 indeed, didn't notice. Will get this sorted, thanks! |
) * fix: update minimatch to 3.1.5 to resolve security vulnerabilities Bumps minimatch from 3.1.2 to 3.1.5, the latest patch in the 3.x line. This resolves the following CVEs: - GHSA-3ppc-4f35-3m26 (ReDoS via repeated wildcards, high severity) - GHSA-7r86-cg39-jmmj (ReDoS via multiple non-adjacent GLOBSTAR segments, high severity) - GHSA-23c5-xmqv-rm74 (ReDoS via nested *() extglobs, high severity) Fixes #206 * chore: update yarn.lock for minimatch 3.1.5
|
Published the |
Summary
Bumps
minimatchfrom3.1.2to3.1.5— the latest patch release in the 3.x line. This is a non-breaking, patch-level update that resolves three high-severity ReDoS vulnerabilities:matchOne()combinatorial backtracking via multiple non-adjacent GLOBSTAR segments*()extglobs generate catastrophically backtracking regular expressionsThis causes downstream Dependabot alerts for all consumers of
serve-handler(includingserve).Fixes #206