Pass oldSections value to refreshTableSections() method.#107
Open
cgossain wants to merge 1 commit intovenmo:masterfrom
Open
Pass oldSections value to refreshTableSections() method.#107cgossain wants to merge 1 commit intovenmo:masterfrom
oldSections value to refreshTableSections() method.#107cgossain wants to merge 1 commit intovenmo:masterfrom
Conversation
Not sure it this was intentional, but the the old sections were not being passed to the `refreshTableSections()` method, preventing the incremental updating behaviour that appears to already be implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure it this was intentional, but the the old sections were not being passed to the
refreshTableSections()method, preventing the incremental updating behaviour that appears to already be implemented.Also note that I made the
sectionsargument of therefreshTableSections()method nonnull because the property on the data source is also nonnull.This answers the question mentioned here: #89