feat(aggregate): expose final flush - #26437
Draft
ArunPiduguDD wants to merge 1 commit into
Draft
ArunPiduguDD wants to merge 1 commit into
ArunPiduguDD wants to merge 1 commit into
Conversation
Allow aggregate wrappers to drain open event-time buckets directly during shutdown. Environment: Datadog workspace Co-Authored-By: Pi OpenAI GPT-5.6 <noreply@pi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
Aggregate::flush_finalpublicly so wrappers can drain open event-time buckets during shutdown without constructing and driving a temporary transform stream.References
Related: event-time aggregation support
Vector configuration
N/A — this only exposes an existing aggregate transform method.
How did you test this PR?
cargo fmt --all -- --checkmake test FEATURES="transforms-aggregate" SCOPE="aggregate"(48 passed)FEATURES="transforms-aggregate" make check-clippyreaches an unrelated pre-existingclippy::unused_asyncfailure insrc/test_util/http.rsDoes this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.