Conversation
Sink conversions need a canonical in-memory trace that can hold OTLP and Datadog fields without stuffing them into a LogEvent map. Add `vector_core::event::typed_trace` behind the typed-trace feature and leave `Event::Trace` as the legacy newtype so sources and the topology stay unchanged. The type encodes the data types specified in RFC 25329 plus the invariants later mappings rely on.
bruceg
added
domain: traces
github-actions
Bot
added
the
docs review on hold
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sink conversions need a canonical in-memory trace that can hold OTLP and Datadog fields without stuffing them into a LogEvent map. Add
vector_core::event::typed_tracebehind the typed-trace feature and leaveEvent::Traceas the legacy newtype so sources and the topology stay unchanged.The type encodes the data types specified in RFC 25329 plus the invariants later mappings rely on.
References
Vector configuration
N/A
How did you test this PR?
N/A code adds no active functionality
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.git merge origin masterandgit push.