Conversation
pront
marked this pull request as ready for review
September 18, 2026 14:39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb5fc5f4cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
enabled auto-merge
September 18, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
File cleanup must retain the path when a task fails or panics. Use Tokio's existing
JoinMapto handle that bookkeeping, preparing the same approach for the notification-driven file source.Summary
Replace the cleanup loop's
JoinSetand task-ID map withtokio_util::task::JoinMap. Enablejoin-mapon the existing dependency; preserve deletion and error reporting behavior.References
Preliminary extraction from #26429.
Vector configuration
No configuration changes.
How did you test this PR?
file-sourceandfile-source-commontests passed.JoinMapto bothifilecall sites locally: all 14 E2E tests passed, including truncate/regrow and restart coverage. Both call sites use unique paths.ifileworkspace Clippy check also passed withifile-tests,sources-fileenabled.unused_asyncerror atsrc/test_util/http.rs:51.Does this PR include user facing changes?
Contributor Guidelines
Followed the repository contribution guidance.